Acerchicken / df-frontend-2023

https://df-frontend-2023-silk.vercel.app
0 stars 0 forks source link

Submission for assignment 1. #1

Open Acerchicken opened 1 year ago

Acerchicken commented 1 year ago

https://df-frontend-2023-fytx.vercel.app/

zlatanpham commented 1 year ago

Hello @Acerchicken, good work!

Requirements

Final result: ✅ passed 70% of requirements

Feedback

We also have some comments for your work:

  1. Should use <button /> for clickable element. Also, icon buttons should have aria-label support for better accessibility https://github.com/Acerchicken/df-frontend-2023/blob/f87e1567c905fbd4e55b66b441bd779b32c65310/assignment-1/index.html#L27

  2. Should use <form /> element for the search function https://github.com/Acerchicken/df-frontend-2023/blob/f87e1567c905fbd4e55b66b441bd779b32c65310/assignment-1/index.html#L21-L24

  3. Use consistent naming conventions. For instance, you have both camelCase (containerUser) and PascalCase (SearchBox). Sticking to one convention makes the codebase easier to read and maintain.

  4. Avoid using inline JS in your HTML. Instead, moving the JS code using .addEventListener() in script.js to maintain separation of concern

  5. Instead of binding delete function to every single element, consider adopting event delegation. https://github.com/Acerchicken/df-frontend-2023/blob/f87e1567c905fbd4e55b66b441bd779b32c65310/assignment-1/script.js#L86