search

Acerchicken / df-frontend-2023

https://df-frontend-2023-silk.vercel.app
0 stars 0 forks source link

Submission for assignment 3. #3

Open Acerchicken opened 1 year ago

Acerchicken commented 1 year ago

https://df-frontend-2023-93uj.vercel.app/

zlatanpham commented 1 year ago

Hello @Acerchicken! Thanks for the submission! We have some comments for your work:

Requirements

Final result: ❌ failed

Feedback

  1. There’s no need to explicitly declare the type here since TypeScript can infer it from the initial value. https://github.com/Acerchicken/df-frontend-2023/blob/30e22f5301e31bbf90f9337b10b7fed83ef89fed/assignment-3/src/App.tsx#L8
  2. This can be simplified to setBooks: (book[]) => void https://github.com/Acerchicken/df-frontend-2023/blob/30e22f5301e31bbf90f9337b10b7fed83ef89fed/assignment-3/src/components/SearchBook.tsx#L11
  3. Can use button instead of span to avoid extra a11y attributes https://github.com/Acerchicken/df-frontend-2023/blob/30e22f5301e31bbf90f9337b10b7fed83ef89fed/assignment-3/src/Layouts/Body.tsx#L44-L49
  4. The list cannot be recovered after using the search function. image

Although the result may not be what you were expecting, I believe you did a pretty good job of implementing TypeScript and addressing clear ESLint warnings. Keep learning and coding!