AchetaGames / Epic-Asset-Manager

A frontend to Assets purchased on Epic Games Store
https://flathub.org/apps/details/io.github.achetagames.epic_asset_manager
MIT License
386 stars 21 forks source link

Temp files deleted before finished extracting #244

Open ghost opened 1 year ago

ghost commented 1 year ago

Describe the bug Trying to download HackNSlashV3 to play around with. It has 868 files but only 861 is extracted because all temp files are deleted before extraction is finished. Making it impossible to download.

To Reproduce Steps to reproduce the behavior:

  1. Download HackNSlashV3
  2. Download finishes
  3. Only 861 files are extracted and exist, missing 7 files
  4. Can't redownload missing files or anything

Expected behavior All 868 files are extracted. No missing files.

Screenshots Screenshot_20230920_154258-1

Desktop (please complete the following information):

aknarts commented 1 year ago

That is strange. Does it get stuck on the "Extraction" and never finishes? How did you figure the amount of files?

The way it works is there is a chunk list and a file list kind of linked together, a chunk can contain multiple files or pieces of files and only after all of them are read this should get deleted. I will take a look if there is a hole there that removes it before. I can also just redownload the chunk if it is missing at the time of extraction which would be a workaround, though not a pretty one as that would mean redownloading things.

ghost commented 1 year ago

That is strange. Does it get stuck on the "Extraction" and never finishes? How did you figure the amount of files?

Yes it gets stuck. Sorry I had difficulty showing it but if you hover your mouse on the extraction bar it shows the amount in X/X so it gets stuck on 861/868

The way it works is there is a chunk list and a file list kind of linked together, a chunk can contain multiple files or pieces of files and only after all of them are read this should get deleted. I will take a look if there is a hole there that removes it before. I can also just redownload the chunk if it is missing at the time of extraction which would be a workaround, though not a pretty one as that would mean redownloading things.

I tried redownloading but the download never starts as it shows that everything is installed and completed. I only have an issue with this one asset so far, the others I have seem to download okay.

aknarts commented 1 year ago

Would you be able to send me the asset manifest? Depending on where you get EAM from that gives the location... figuring out the ID is the hard part :)

It is somewhere in ~/.var/app/io.github.achetagames.epic_asset_manager/cache/epic_asset_manager for flatpak or ~/.cache/epic_asset_manager/

Sadly I do not think I currently cache the download manifest, which would contain the actual download links.. but maybe this does give me some idea.

ghost commented 1 year ago

Sure thing.

a54a32a1f168453780954296a9546aac.zip