search

AchimPieters / esp32-homekit-demo

esp32-homekit-demo
https://www.studiopieters.nl
MIT License
15 stars 2 forks source link

Update README, remove bad Icon file with embedded CR #8

Closed gojimmypi closed 1 month ago

gojimmypi commented 1 month ago

Hi @AchimPieters

Perhaps you'd consider reviewing PR's on my branch before merging and reverting? I need to re-apply all those changes in each subsequent PR. The most recent one could have been solved with a minor update to only the version in idf_component.yml after I push an updated component that disables hardware acceleration to save on space.

This PR removes an annoying file that Visual Studio is not happy with: an Icon filename with an embedded CR character. It is quite odd an each time I struggle with a proper commit to remove it, as even the commandline had quirks dealing with it.

Stand by for additional pull requests that use the managed components.

AchimPieters commented 1 month ago

@gojimmypi Sorry about that, was over enthusiastic! Will review your PR's on your branch.

AchimPieters commented 1 month ago

@gojimmypi I re-re-verted your pull request see my repository, I'm really, really, really sorry...

gojimmypi commented 1 month ago

re-re-verted

no worries, I've had plenty of struggles with git myself.