Closed elbachir-one closed 3 months ago
Hello again just woke up,
I also saw that you added a way for void users to install gowall , pretty cool :) good job have you tested it to make sure it works? I really have no idea how void does their stuff ( spin up a quick vm and check on a fresh install if you haven't please , unless you installed gowall on your void install this way)
One change i would want is to please add a Community themes
section under the Theme
section so the users dont get overwhelmed by the amount of themes
ex.
Just finished testing your PR
Everything is fine except for the sweet
theme which produces really bad images so i would like to remove it. ( You can see the 3 examples below )
Example 1: https://freeimage.host/i/dTILp0G Example 2: https://freeimage.host/i/dTIQvkl Example 3: https://freeimage.host/i/dTIZHEg
I plan to merge a PR soon which will allow anyone to just pass a config of a theme so future users can just use whatever theme they like.
As soon as you remove the sweet
theme and give me the okay that the void installation of gowall works i will merge this
EDIT: dont forget to pull the new changes and update your pr
Mad a new PR.
Looks good to me at a first glance. I will test everything tomorrow and merge it since it is very late at night right now.