search

Achno / gowall

A tool to convert a Wallpaper's color scheme / palette
https://achno.github.io/gowall-docs/
MIT License
427 stars 8 forks source link

Add FreeBSD platform support #15

Closed nxjosephofficial closed 19 hours ago

nxjosephofficial commented 1 day ago

Hi. Nice tool you've made! :star: :100:

I do want to package gowall for FreeBSD platform that I am daily driving. I did sent a port request to FreeBSD bugzilla and waiting for it to get accepted into FreeBSD repositories and ports tree soon.

I made two patches locally that adds FreeBSD platform support by editing those two files: utils/url.go and internal/image/image.go. After added FreeBSD support, gowall seems to work on FreeBSD.

I made these changes in my fork and created this PR. Also attached it as a txt file.

patch.txt

in case of "linux", it seems to use xdg-open and that's already available on FreeBSD. I added a "freebsd" case with same command.

Thanks in advance.

Achno commented 1 day ago

Hello there @nxjosephofficial thank you for the kind words,

If you want to be a maintainer and package gowall for FreeBSD like others are for NixOS and Void ( i package for the AUR) , be my guest, it would be lovely :)

As for the patch i will merge it tommorow after i spin up FreeBSD for the first time in my life and test that it works, since im not near my computer right now and it would be pretty late when i come back.

nxjosephofficial commented 1 day ago

Hello there @nxjosephofficial thank you for the kind words,

You are welcome.

If you want to be a maintainer and package gowall for FreeBSD like others are for NixOS and Void ( i package for the AUR) , be my guest, it would be lovely :)

Thank you, I already did package (this means porting software to FreeBSD) gowall for FreeBSD but it is not in official freebsd ports tree (package tree) and repositories yet. You can track this link.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282799

As for the patch i will merge it tommorow after i spin up FreeBSD for the first time in my life and test that it works, since im not near my computer right now and it would be pretty late when i come back.

Okay, I will publish the package into my unofficial FreeBSD ports overlay now, you can use it after you install FreeBSD to install the gowall on FreeBSD or, better, you can clone the git repo and apply my patches then test. I assume you are going to install FreeBSD into a virtual machine. I already tested gowall but it would be better if you can test it.

Feel free to ask me questions about installing FreeBSD.

Achno commented 19 hours ago

Tested and works fine, merging.

nxjosephofficial commented 16 hours ago

Nice, thanks. In readme, there are commands to install gowall for some distros and I can make a PR when gowall is passed into FreeBSD repositories, both quarterly (lts packages branch) and latest (rolling packages branch)

Achno commented 15 hours ago

There is no need to waste time with PR's for the README right now. Since i made the docs page, i will clean up the readme and change it a lot in the coming days.

After im done with that, you can make the PR for it for the README and i will add it to the docs page as well :)