search

AchrafReyani / educom-webshop-basis

0 stars 0 forks source link

Er staat nog teveel HTML code buiten functies, dit is niet de opdracht #18

Open JeroenHeemskerk opened 5 months ago

JeroenHeemskerk commented 5 months ago

Op veel plaatsen staat nog HTML code buiten functies https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/index.php#L1-L9 https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/contact.php#L1-L9 https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/contact.php#L67-L147

Of er staat PHP code BUITEN functies https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/contact.php#L13-L59 https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/header.php#L1 https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/menu.php#L2-L6 https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/about.php#L1-L3

Dit is allemaal NIET de bedoeling,

De bedoelding is dat alle files beginnen met <?php en dat alle echo's in functies staan dus https://github.com/AchrafReyani/educom-webshop-basis/blob/c0d27255493e0c696902ee526f99974169c62981/footer.php#L1 Wordt:

<?php 
 function showFooter() {
    echo "<footer>&copy; Copyright 2024 Achraf Reyani</footer>"; 
 }
?>

en zou ik in index.php opnemen in plaats van een eigen file