Achronite / mqtt-energenie-ener314rt

MQTT interface for Energenie ENER314-RT add-on board for the Raspberry Pi, designed for use by Home Assistant.
MIT License
13 stars 5 forks source link

Minor quality of life changes (capital Energenie, missing semi-colon, package version outputs) #42

Closed webash closed 1 year ago

webash commented 1 year ago

Hello! Again, thanks for the great work on this. I'd like to be able to help make it more awesome, if you'd be interested in that!

This first pull request contains some very minor suggestions that have helped me so far when setting up my development environment:

Hope you like this and are interested in further collaboration. I've submitted #41 too that might be even further controversial, so I'll split it into its own for a separate discussion

(apologies for closing the first version of this PR, I accidentally submitted from my develop branch rather than a feature-specific branch and I am new to this so wasn't sure how to repoint it without recreating the PR)

webash commented 1 year ago

According to this hard to find bit on this page about discovery messages, sw already represents sw_version... I'm not sure why this isn't on the page you linked!

image