search

Achronite / mqtt-energenie-ener314rt

MQTT interface for Energenie ENER314-RT add-on board for the Raspberry Pi, designed for use by Home Assistant.
MIT License
13 stars 5 forks source link

Merge/contribute project efforts #46

Closed genestealer closed 11 months ago

genestealer commented 1 year ago

Hi, firstly this is fantastic work and thank you for making this. :)

I would migrate over from my node-red instance (using node-red-contrib-energenie-ener314rt) to mqtt-energenie-ener314rt but I notice I added some extra functionality into my MQTT discovery on node-red, which I would like to suggest we add into this.

My repo: https://github.com/genestealer/node-red-energenie-ener314rt-home-assistant-mqtt

Happy to make all the changes and then submit a pull request.

  1. Smart Plug Plus (MIHO005) and Smart Monitor Plug (MIHO004) don't seem to be reporting all their data on your code: Mine: image Yours: image
genestealer commented 1 year ago

Removed 1 and 2 and I see this was already completed, my mistake :(

genestealer commented 1 year ago

Work complete. PR raised. Please let me know if your unhappy with anything :)

https://github.com/Achronite/mqtt-energenie-ener314rt/pull/48

genestealer commented 1 year ago

New PR raised: https://github.com/Achronite/mqtt-energenie-ener314rt/pull/51

Achronite commented 1 year ago

Reopened as will be closed when released to master

Achronite commented 1 year ago

@genestealer Please take a look at develop, I think I've finished my updates.

NOTE: You didn't fix the VALVE_STATE number, you had HA heat = eTRV open (0) instead of HA heat = eTRV auto (2)

genestealer commented 12 months ago

@genestealer Please take a look at develop, I think I've finished my updates.

NOTE: You didn't fix the VALVE_STATE number, you had HA heat = eTRV open (0) instead of HA heat = eTRV auto (2)

Thank you, will look now.