Closed Achronite closed 11 months ago
@genestealer Thank you for all your help, it is much appreciated. :-)
Can you give the code a quick once over please to ensure your agreed changes have been added as discussed?
Please do not execute the merge.
Brilliant, thank you. I will have a look shortly.
@Achronite everything ok?
Yeah, I'm OK just far too busy at the moment. I'll try and get this released soon.
No worries at all. You might see that I've raised another PR as well, to leverage the config file to set the default enable or disabled behaviour on the frequency and voltage reporting.
On Fri, 3 Nov 2023, 10:35 am Achronite, @.***> wrote:
Yeah, I'm OK just far too busy at the moment. I'll try and get this released soon.
— Reply to this email directly, view it on GitHub https://github.com/Achronite/mqtt-energenie-ener314rt/pull/53#issuecomment-1792205678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHXLQUNCEDQLBH3TGYI37DYCTCITAVCNFSM6AAAAAA56ZAZAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGIYDKNRXHA . You are receiving this because you were mentioned.Message ID: @.***>
Closes #46, #47, #49, #52