search

Acidham / chromium-hist-bookmarks

Search in Chromium History and Bookmarks
133 stars 17 forks source link

Not showing favicons #20

Closed moritzWa closed 2 years ago

moritzWa commented 2 years ago

Problem: My eyes use visual imagery to lock on a search target i.e. small images help to find the correct bookmark result Solution: fetch the favicons from a service like the (undocumented) https://icons.duckduckgo.com/ip3/${baseDomain}.ico

Acidham commented 2 years ago

Good idea! I added the feature, but the issue is it delays workflow execution. Therefore, I added a flag in settings to enable/disable.

moritzWa commented 2 years ago

Awesome, that was fast! This works for history now but somehow the favicons are not updated for the bookmark search for me (even after re-installing the workflow and re-starting alfred)

image

history works

image
moritzWa commented 2 years ago

To speed this up, it might be nice to cash the favicons or add an async job that fetches favicons for newly visited history-URLs recently created bookmarks in the background?

Acidham commented 2 years ago

For time being I implemented it only for history search.

Icons will be cached but not async. but it is on my todo list to fetch async.

Acidham commented 2 years ago

Asynchronous Cache is implemented. Search should be displayed faster now.

moritzWa commented 2 years ago

For time being I implemented it only for history search. My request was actually mostly aimed at the bookmarks so having that would be great!

Acidham commented 2 years ago

I am working on it.