search

Ackee-Blockchain / trident

Rust-based framework to Fuzz and Integration test Solana programs to help you ship secure code.
https://ackee.xyz/trident/docs/latest/
MIT License
205 stars 18 forks source link

Add more specific err message for invalid struct #164

Closed cryptopapi997 closed 4 months ago

cryptopapi997 commented 4 months ago

Follow up from https://github.com/Ackee-Blockchain/trident/issues/160 , where the issue was camel -> kebab -> camel case conversion isn't always constant. This was hard to determine since trident didn't say which struct was the problem. Saying which one it was (and seeing that it sees it incorrectly capitalized) would've made this easy to debug, so this PR changes this.

Maybe trident not supporting vars with multiple sequential capital letters could be specified in the docs somewhere too, but wasn't sure where the best spot for this is, so up to you guys.

lukacan commented 4 months ago

Hello @cryptopapi997 , thanks for the PR , we will have a look and get back to you later :)

cryptopapi997 commented 4 months ago

Adapted according to your review, feel free to take another look @lukacan

Ikrk commented 4 months ago

Hi @cryptopapi997, thank you, it looks good to me! Can you please rebase your branch on develop and change this PR to merge to develop branch? We are currently pushing new features into develop branch and merge to master only on release.

We might however reconsider this branching strategy in the (short) future in order to make contributions easier...

cryptopapi997 commented 4 months ago

Got it, just rebased & resolved merge conflicts - feel free to take a final look @Ikrk

Ikrk commented 4 months ago

Thanks, merged!