search

AckeeCZ / ACKategories

Swift tools, cocoa subclasses and extensions.
MIT License
56 stars 13 forks source link

🐛 Fix navigation controller's delegate on flow coordinator that is navigation root #100

Closed LukasHromadnik closed 3 years ago

LukasHromadnik commented 3 years ago

Our current implementation has a problem where dying child coordinator that was navigationController?.delegate passes this responsibility to its parent. But if the parent has navigationController == rootViewController then the delegate method will also stop the parent flow. This behavior is caused by the previous fix. 😔

Currently we are not able to resolve this issue with better fix than checking if the navigationController != rootViewController

Checklist

github-actions[bot] commented 3 years ago

@LukasHromadnik your pull request is missing a changelog!