search

AckeeCZ / ACKategories

Swift tools, cocoa subclasses and extensions.
MIT License
56 stars 13 forks source link

Ios deployment #135

Closed freed0m266 closed 11 months ago

freed0m266 commented 11 months ago

Checklist

github-actions[bot] commented 11 months ago

@freed0m266 your pull request is missing a changelog!

olejnjak commented 11 months ago

Hi, what is the motivation here, I don't see a single reason here for increasing deployment target to 14.0. 12.0 is acceptable as that is the lowest supported by Xcode 15.x

And definitely if bumping deployment targets, don't forget about SPM and Cocoapods.

freed0m266 commented 11 months ago

Hi 👋 My motivation was just a warning in projects where I'm using ACKategories, that's all. 🙂

olejnjak commented 11 months ago

Well then iOS 12 is the way to go as it is the lowest supported version in Xcode 15 and we also need iOS for some of our projects.

babacros commented 11 months ago

@freed0m266 Hey, you can just create a fork for this purpose.

olejnjak commented 11 months ago

In #137 I bumped deployment target to iOS 12, so this should be solved.