Fix a typo - Githubissues

AckeeCZ / ACKategories

Swift tools, cocoa subclasses and extensions.

MIT License

56 stars 13 forks source link

Closed michalsrutek closed 4 years ago

olejnjak commented 4 years ago

Hello thanks for your interest, but this is not a typo 🙂 see https://www.grammarly.com/blog/its-vs-its/ 🙂

janmisar commented 4 years ago

@olejnjak According to your link (and also my knowledge btw), @michalsrutek is right I think 🤔😄

olejnjak commented 4 years ago

Two verbs in a single sentence like really?

returns it is localized value or self

I don't think that it makes any sense

janmisar commented 4 years ago

Maybe I’m confused 😄 but the suggestion is “its” and now we have “it’s” so current version is wrong, isn’t it..?

olejnjak commented 4 years ago

yayks my bad 🙈

michalsrutek commented 4 years ago

No worries, that's what PRs are for :D

olejnjak commented 4 years ago

Either way please @michalsrutek add your entry to changelog so we can merge your PR 🙂

michalsrutek commented 4 years ago

Thanks, @olejnjak. Pushed the change. Is it alright now?

olejnjak commented 4 years ago

Yes, seems fine 🙂 Thanks for you contribution 🙂