search

AckeeCZ / ACKategories

Swift tools, cocoa subclasses and extensions.
MIT License
56 stars 13 forks source link

TableHeaderFooterView should inherit from UITableViewHeaderFooterView #91

Closed olejnjak closed 4 years ago

olejnjak commented 4 years ago

As TableHeaderFooterView inherits from UIView and not UITableViewHeaderFooterView, its readableContentGuide behaves differently from UITableViewCells.

It should definitely inherit from UITableViewHeaderFooterView but I think it would be better to make this change somehow breaking as UITableViewHeaderFooterView has e.g. defined background color. We should think about good breaking change that would force everyone to think about it.

https://github.com/AckeeCZ/ACKategories/blob/66874990bf1298523d520fe8c0f94e273d516e83/ACKategories-iOS/TableHeaderFooterView.swift#L4

olejnjak commented 4 years ago

If we cannot come up with better name, for now we will use SelfSizingTableHeaderFooterView for new class and the existing one will be marked deprecated.