AckerApple / ack-angular-webcam

MIT License
37 stars 19 forks source link

Review to remove ref bind #22

Closed AckerApple closed 7 years ago

AckerApple commented 7 years ago

The input ref and output refChange as not needed as Angular already provides a template-to-class references.

This:

<ack-webcam [(ref)]="webcam"></ack-webcam>

Should now become this:

<ack-webcam #webcam></ack-webcam>

This will cause a breaking change, removing ref. Increase minor version number

AckerApple commented 7 years ago

It doesn't work exactly like I thought. To use a template variable as such, also requires the use of @ViewChild() otherwise the template variable is only available to the template and NOT the class