search

AckerApple / angular-file

Angular components for user file select, drop, and more
http://ackerapple.github.io/angular-file/
MIT License
128 stars 40 forks source link

Request: make "selectable" binding checked on changes #57

Open conrado-l opened 5 years ago

conrado-l commented 5 years ago

I think it would be a good idea to make the "selectable" input/prop bindable.

I'm making a feature and when there is a loader, I would set "selectable" to false until the loading finishes, I came to realize that the "selectable" input is being checked on ngOnInit, and because of it, it's not bindable.

I think every input or almost every input should be bindable for maximum flexbility.

Thanks for your time and mantaining this awesome library.

AckerApple commented 5 years ago

https://github.com/AckerApple/angular-file/blob/development/src/file-upload/ngf.directive.ts#L33

AckerApple commented 5 years ago

Oh I see, it only checks on init. Ok. Maybe make a pull request then please