search

AckerApple / pdfbox-cli-wrap

A wrapper for making PDFBox CLI commands
MIT License
5 stars 5 forks source link

Get npm test working #2

Closed tknobi closed 6 years ago

tknobi commented 6 years ago

just wanted to run the mocha test and found this typo :)

AckerApple commented 6 years ago

reviewing now

AckerApple commented 6 years ago

Please confirm the typo is a case sensitivity

I would appear so but the test works on my Mac

Perhaps the fix would be to change the require statement and NOT the file name? But I am not picky

Just want to confirm the typo is a case sensitive correction and if so I am good to merge

tknobi commented 6 years ago

Thanks for the fast answer ;)

Please confirm the typo is a case sensitivity

Yes it is

I would appear so but the test works on my Mac

With the typo, the test did not work on my Linux Mint.

Perhaps the fix would be to change the require statement and NOT the file name? But I am not picky

I don't care, do it like you prefer ;)

AckerApple commented 6 years ago

Thank you extra kindly. I have merged. I will get to publishing to npm after I try to integrate Appveyor and Travis testing.

As seen in new issue #2