search

AckerApple / pdfbox-cli-wrap

A wrapper for making PDFBox CLI commands
MIT License
5 stars 5 forks source link

Use eslint #5

Closed tknobi closed 6 years ago

tknobi commented 6 years ago

You could use eslint to get clean js code.

Good point to start: Eslint: getting started useful standard rules from airnbnb integrate it in vs code editor

AckerApple commented 6 years ago

clean code? Oh you trying to start sumfin?

Yo just messin' with you. Me and my brother have gone back and forth over the lint.

I'll write the code in Typescript and cast it to JS code long before I will lint. Lint'ing is still too restrictive to me and we could go circles on and on...

Thank you kindly. Not likely to happen.

What are your extra thoughts I might want to hear? I've been slapping down the lint for some years now

tknobi commented 6 years ago

Just an idea ;)

I like it if my code is clean, so i'm using a linter in most of my projects...

AckerApple commented 6 years ago

I've had great success moving to TypeScript and then running one of them NodeTs interpreters. It gives me far more descriptive code with more scripting like declarations that ultimately results in cleaner more condensed code. I like that route versus a lint enforcer but its kinda comparing apples to oranges so I know my points are hella debatable and in some cases invalid.........

Closing point as to why I may still do nothing and not make a change.... I feel the less requirements to build a project, the more anybodies are attracted to make a pull request. I've not worked on packages based on complicated restrictive build processes.

With unit tests, I'm ok with "dirty" code. I love my code style, so suck it!

Nah, you be good. Love a good chat. I'm cool to leave this issue open for a while. Bout time this package got some attention, it's good shit I use in production.

AckerApple commented 6 years ago

This package's JS files are now built from TS files.

Typings have not yet been utilized to there fullest but Typescript code checking already found a bunch of items I needed to correct.

The future of this task would be to increase the amount of typings so that this package is NOT too loose.