I created a branch in my fork, I deleted some of the types, switched to defnitely, and got build and tests to work.
Will work on deleting the rest of the types later.
One issue I had was some things are typed as Error, when really it should be a stripe.Error.
I'm assuming that it was just typed as Error for convenaince, and to get that one shared message property, and will liberaly change to stripe.Error.
IDK how that works with the exported library? Will it have the stripe types also? Or will user have to install stripe types?
That should be documented. Maybe we should have it as a peer dependency?
Currently in the package.json I added the types as a devDependency.
Something to consider is adding more complete typing to the stripe instance. For example, I'm using
What about using the definitelytyped typings?
Originally posted by @yringler in https://github.com/AckerApple/stripe-angular/issues/42#issuecomment-752972863
I created a branch in my fork, I deleted some of the types, switched to defnitely, and got build and tests to work.
Will work on deleting the rest of the types later. One issue I had was some things are typed as Error, when really it should be a stripe.Error. I'm assuming that it was just typed as Error for convenaince, and to get that one shared message property, and will liberaly change to stripe.Error.
IDK how that works with the exported library? Will it have the stripe types also? Or will user have to install stripe types?
That should be documented. Maybe we should have it as a peer dependency?
Currently in the package.json I added the types as a devDependency.