AckerApple / stripe-angular

Angular to Stripe module containing useful providers, components, and directives
MIT License
48 stars 17 forks source link

Added [ElementsCreateOptions] to StripeCard #48

Closed va2ron1 closed 3 years ago

va2ron1 commented 3 years ago

A new prop named elementsOptions has been added of type ElementsCreateOptions. Note: The bundles files don't have the changes.

AckerApple commented 3 years ago

Do you have any documentation or links indicating difference between these two?

Maybe add it to README?

AckerApple commented 3 years ago

Maybe rename to createOptions?

va2ron1 commented 3 years ago

Yes, there's one in the Stripe API Documentation.

  1. ElementsCreateOptions - https://stripe.com/docs/js/elements_object/create
  2. ElementsOptions - https://stripe.com/docs/js/elements_object/create_element?type=card

Basically the first is the options for the Elements instance in which you can set custom fonts or set a fixed language. And the second, in this case, are the options for the card element (style, classes, value, ...).

Navigating on the web a found this that can be helpful for future additions or implementations:

Note: I will rename it to createOptions, I didn't think it this way.

selected-pixel-jameson commented 3 years ago

Can we get this merged and released? This is a huge piece of necessary functionality.

AckerApple commented 3 years ago

I forgot about this and have been swamped. @selected-pixel-jameson if you will validate and provide some valuable feedback, I will attempt to escalate review and merge

AckerApple commented 3 years ago

This has been merged

@selected-pixel-jameson this was not huge missing functionality, look at the files changed. It was just docs and a data typing

AckerApple commented 3 years ago

Ah I found #49