Closed aemonge closed 9 months ago
Cool @aemonge! I hope to look at this in detail soon.
One comment for the future, it's sometimes easier to have different PRs for different new features. Also in particular if you do some formatting since this can obscure the actual changes. I find it easier if that's in a separate PR as well but at least a separate commit is helpful :)
@AckslD you're 100% right. I've gone a bit extream and forgotten my coding manners. If it's helpfully, I can close this PR and create them separated.
No problem @aemonge!
I'll look at this as soon as I can but just a bit busy atm :)
Hey, I've rebased and fixed your mentions
@aemonge, I did some final small changes which I didn't want to bother you with (for example there was already a .stylua.toml
so I removed yours. Thanks a lot for this PR, very nice!
Happy to contribute <3
Change venv automatically.