Closed b0lle closed 4 months ago
Hey, thanks for reviewing :). You are right. I think you can even configure virtualenv to create the venvs in project. In poetry you also have the in-project option to define where the venv should live.
I personally prefer the in-project option for several reasons:
I had tested the code within my setup and it works pretty well. But I didn't had the chance to test it with a common dir, like yours. Can you try it, after I fixed the code which regards to your comment?
That makes sense! I tried the version in my own setup and seems to work from what I can tell :+1:
I finished my additions :)
Thanks for the nice contribution!
I had some trouble activating venvs which are defined in-project (e.g. /Users/User/project/.venv) and realized that this is not supported. The virtual environment has to be created with pyenv, so that the plugin can parse the venv-name out of the
pyvenv.cfg
file (promt variable).If a venv was found in-project, it takes precedence over venvs defined in the "centralized" venvs folder in user directory.
Let me know what you think about the additions. If thats something interesting for anybody I could look for a solution for venvs which were not created with pyenv.