Acly / comfyui-inpaint-nodes

Nodes for better inpainting with ComfyUI: Fooocus inpaint model for SDXL, LaMa, MAT, and various other tools for pre-filling inpaint & outpaint areas.
GNU General Public License v3.0
490 stars 35 forks source link

Batch size issue #28

Closed Latentnaut closed 2 weeks ago

Latentnaut commented 4 months ago

I noticed I cannot create a batch with the node Repeat Latent Batch.

Is is possible to achive this in another way?

Acly commented 4 months ago

You can Repeat Latent Batch before passing it to the sampler as usual. What exactly is the issue?

Latentnaut commented 3 months ago

Here an example. For some reason Repeat Latent Batch is not giving me 4 images, only 1.

image

Acly commented 3 months ago

Strange, it looks the same as what I tried, worked for me. Maybe something else influences it?

Latentnaut commented 3 months ago

I've took a second view and the Repeat Latent Batch is working well when I hook the Save node after de VAE Decode, as expected.

My failure was I hooked the Save node AFTER theImageCompositeMasked node, obviously it was taking only the 1st generated image, so I thought the batch was not working well.

That's being said, I wonder why ImageCompositeMasked node is there, as I don't notice any difference. What is it useful for?

Acly commented 3 months ago

I would've expected ImageCompositeMasked to work on batches too.

It makes sure you get the original input image in places where the mask is 0. The output has gone through VAE encode + decode, which degrades quality.

lldacing commented 3 months ago

I've took a second view and the Repeat Latent Batch is working well when I hook the Save node after de VAE Decode, as expected.

My failure was I hooked the Save node AFTER theImageCompositeMasked node, obviously it was taking only the 1st generated image, so I thought the batch was not working well.

That's being said, I wonder why ImageCompositeMasked node is there, as I don't notice any difference. What is it useful for?

image You can do this. @Latentnaut

Latentnaut commented 3 months ago

SUPER, just what it was missing ;)