Acly / krita-ai-diffusion

Streamlined interface for generating images with AI in Krita. Inpaint and outpaint with optional text prompt, no tweaking required.
https://www.interstice.cloud
GNU General Public License v3.0
6.97k stars 343 forks source link

Upscale issue #8: the rendered layer’s title doesn’t reflect the upscale job performed #1282

Open valery016 opened 1 month ago

valery016 commented 1 month ago

No matter what kind of upscale job has been performed, the resulting layer’s title always looks like this:

[Upscale] 1536x2048 (1786158082)

This makes it difficult to distinguish between the various upscale/refine versions created in the layer stack. The layer title should reflect at least: the upscaler model, the refiner style used, the Strength and the (beginning part of the) prompt used (or none) - similarly to the way it’s implemented in the Generate/Refine part of the plugin.

Acly commented 1 week ago

I don't really like to put that much stuff into the layer name. Generate/refine also only use abbriviated prompt + seed. Resolution feels like the most important thing about an upscale?

valery016 commented 1 week ago

Well, the plugin already appends a hefty cryptical substring to the layer name upon upscale, e.g. (2075337012) - do we really need that? Instead, at least a substring indicating whether a refine operation was applied could be added, like "refine 30% unblur med", or something. Will serve as a useful reminder for dealing with this layer later on among others in the stack, to indicate that no further refine needed. (Believe me, it's easy to forget when doing numerous upscales and optional refinements one after another.)

No need to add the prompt text in this case, agreed.