Acly / krita-ai-diffusion

Streamlined interface for generating images with AI in Krita. Inpaint and outpaint with optional text prompt, no tweaking required.
https://www.interstice.cloud
GNU General Public License v3.0
6.98k stars 344 forks source link

Graph: ComfyUI Resets Negative "Min" Values to 0 When Loading Saved JSON Workflows saved via the Krita Plugin #1381

Closed patrickchamp closed 1 week ago

patrickchamp commented 2 weeks ago

Description: After saving a custom workflow using the Krita AI Diffusion plugin, negative "Min" values in Parameter nodes are reset to zero upon loading the JSON file in ComfyUI. Additionally, the Min value cannot be adjusted back to a negative number within ComfyUI, requiring manual JSON editing after saving the api workflow. This issue complicates small edits to saved workflows and impedes sharing workflows, as any loaded JSON reverts negative values to zero, potentially without other users noticing.

Expected Behavior:

Observed Behavior:

Steps to Reproduce:

  1. Save a custom workflow using the Krita AI Diffusion plugin that has negative "Min" values in Parameter nodes.
  2. Load the saved JSON workflow in ComfyUI.
  3. Observe that all negative Min values in Parameter nodes are reset to zero.
  4. Attempt to set Min values back to negative within ComfyUI; note that it’s not possible.

Additional Information:

Acly commented 2 weeks ago

I think I fixed this today in https://github.com/Acly/comfyui-tooling-nodes/commit/517790d1d6c044f2aab1bc1a9c570caf1138dc6b - if you're using a custom install you can try updating comfyui-tooling-nodes