Acly / krita-ai-diffusion

Streamlined interface for generating images with AI in Krita. Inpaint and outpaint with optional text prompt, no tweaking required.
GNU General Public License v3.0
5.63k stars 252 forks source link

[bug] √ button - Error: <method 'emit' of 'PyQt5.QtCore.py' ...... #827

Closed pendave closed 2 weeks ago

pendave commented 2 weeks ago

image When I click the √ button: image though the new image layer is added.

pendave commented 2 weeks ago

And I also find that the two √ buttons' functions are messed up, they should function like as contrary. image

According to the notion: release-1 18 1-apply image

Without regions, this is a simple way to apply a Live result as a new layer instead of replacing contents, same as previous versions. image

image

Acly commented 2 weeks ago

Not sure I understand.

This lines up with the tooltip description. Maybe the release notes were confusing? What I meant is that the newly introduced button follows the behavior of previous versions.

How did the error happen? Do you have some other behavior configured in settings.json?

pendave commented 2 weeks ago

I mean this button image What I understand it is from

Without regions, this is a simple way to apply a Live result as a new layer instead of replacing contents, same as previous versions.

So the tooltip description should be "Create a new layer with the current result".

But the other button image is used to create a new layer first or directly replace an active layer content. So the tooltip description should be "Copy the current reuslt to the active layer".

Is the rectangle in the icon meaning "area"? If it means "layer" then you are right. image

freecoderwaifu commented 2 weeks ago

Everything is pretty intuitive to be honest: tooltips, icons and functionality. Checkmark icon: apply as is, applies to current layer. Checkmark icon with square below: square = layer, makes a new layer and applies. Simple as. Maybe adding a + to the second icon might give that extra clarity for some who might need it.

pendave commented 2 weeks ago

Everything is pretty intuitive to be honest: tooltips, icons and functionality. Checkmark icon: apply as is, applies to current layer. Checkmark icon with square below: square = layer, makes a new layer and applies. Simple as. Maybe adding a + to the second icon might give that extra clarity for some who might need it.

Cool, + is nice for the design element. image

pendave commented 2 weeks ago
2024-06-18 00:31:52
Traceback (most recent call last):
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\control.py"
    layer.removed.connect(lambda: self.remove(control))
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\control.py"
    self._layers.remove(control)
ValueError: list.remove(x): x not in list

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\model.py"
    return await coro
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\model.py"
    new_input = await self._model._generate_live(self._last_input)
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\model.py"
    cond
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\region.py"
    control=[c.to_api(bounds) for c in list(root.control) + parent_control]
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\region.py"
    control=[c.to_api(bounds) for c in list(root.control) + parent_control]
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\control.py"
    layer = self.layer
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\control.py"
    layer = self._model.layers.updated().find(self.layer_id)
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\layer.py"
    self.update()
  File "C:\Users\pen_d\AppData\Roaming\krita\pykrita\ai_diffusion\layer.py"
    self._layers[id].removed.emit()
SystemError: <method 'emit' of 'PyQt5.QtCore.pyqtBoundSignal' objects> returned a result with an exception set
Acly commented 2 weeks ago

Error looks like the #823 issue

Acly commented 2 weeks ago

Error should be fixed in v1.19.0