AcrylicShrimp / dlsite-manager

Download your DLsite products by one-click!
MIT License
56 stars 7 forks source link

v2.0.0 - Sorting options missing and ambiguous #23

Open theshillito opened 4 months ago

theshillito commented 4 months ago

"Order By" used to have "Product Title", "Purchase Date", etc. Now it's replaced by an ambiguous "Descending" and "Ascending" selection, which seems to be product release date, and that's the only option. image Old style can be seen in https://github.com/AcrylicShrimp/dlsite-manager/blob/main/docs/img-list.png

Could the older sort options be added back in please (I always had it as order by purchase date, since anything I just bought should be at the top). In the interim, this could be better labelled to say what is being ordered.

AcrylicShrimp commented 4 months ago

Let me explain some:

  1. Old style order-by filter is gone, because many fields of product table are removed. This is needed to support indexing "not-owned" products, since DLsite is not giving much product informations for "not-owned" compared to the "owned" ones.
  2. So currently, there is only one field that can be used for order-by filter, is "purchased date" field. The order-by filter after reworking is using this.
  3. But I think the order-by filter behavior is somewhat broken.

Conclusion:

theshillito commented 4 months ago

"purchased date" is really all I want, and the removal of the other sort options makes sense due to lack of data.

For the "not-owned" products, if no "purchased date" is available, is the intention to use folder "creation date" or "modified date" perhaps?

AcrylicShrimp commented 4 months ago

Ah, there was an error in my comment. Currently products are sorted by "registered at", not "purchased date". I'm sorry.

I'll change it to use "purchased date" in next release. And yes, I think I can use ctime or atime for "not-owned' ones. Which do you prefer? I think ctime is typically set by the product maker, so it's better to use atime maybe.