Actelion / openchemlib

Open source Java-based chemistry library
Other
77 stars 28 forks source link

SMARTS Conversion to MOL removes mapping for hydrogen #33

Open Artoria2e5 opened 5 years ago

Artoria2e5 commented 5 years ago

This breaks the [CH2:1]=[CH:2][CH:3]=[CH:4][CH2:5][H:6]>>[H:6][CH2:1][CH:2]=[CH:3][CH:4]=[CH2:5] test case from http://www.daylight.com/meetings/summerschool01/course/basics/smirks.html.

Input:

[CH2:1]=[CH:2][CH:3]=[CH:4][CH2:5][H:6]

Output:

Actelion Java MolfileCreator 1.0

  5  4  0  0  0  0  0  0  0  0999 V2000
    3.4641   -0.5000   -0.0000 C   0  0  0  0  0  0  0  0  0  1  0  0
    2.5981   -0.0000   -0.0000 C   0  0  0  0  0  0  0  0  0  2  0  0
    1.7321   -0.5000   -0.0000 C   0  0  0  0  0  0  0  0  0  3  0  0
    0.8660   -0.0000   -0.0000 C   0  0  0  0  0  0  0  0  0  4  0  0
    0.0000   -0.5000   -0.0000 C   0  0  0  0  0  0  0  0  0  5  0  0
  1  2  2  0  0  0  0
  2  3  1  0  0  0  0
  3  4  2  3  0  0  0
  4  5  1  0  0  0  0
M  END
thsa commented 5 years ago

thanks, this should be fixed with the next nightly update, Thomas

On Mon, Nov 12, 2018 at 2:31 AM Mingye Wang notifications@github.com wrote:

Input:

[CH2:1]=[CH:2][CH:3]=[CH:4][CH2:5][H:6]

Output:

Actelion Java MolfileCreator 1.0

5 4 0 0 0 0 0 0 0 0999 V2000 3.4641 -0.5000 -0.0000 C 0 0 0 0 0 0 0 0 0 1 0 0 2.5981 -0.0000 -0.0000 C 0 0 0 0 0 0 0 0 0 2 0 0 1.7321 -0.5000 -0.0000 C 0 0 0 0 0 0 0 0 0 3 0 0 0.8660 -0.0000 -0.0000 C 0 0 0 0 0 0 0 0 0 4 0 0 0.0000 -0.5000 -0.0000 C 0 0 0 0 0 0 0 0 0 5 0 0 1 2 2 0 0 0 0 2 3 1 0 0 0 0 3 4 2 3 0 0 0 4 5 1 0 0 0 0 M END

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Actelion/openchemlib/issues/33, or mute the thread https://github.com/notifications/unsubscribe-auth/AJpSBirG0jfjMpQvcODPH7QTYk9D5vGnks5uuM9jgaJpZM4YYz2i .

--

The information of this email and in any file transmitted with it is strictly confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, any copying, distribution or any other use of this email is prohibited and may be unlawful. In such case, you should please notify the sender immediately and destroy this email. The content of this email is not legally binding unless confirmed by letter. Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of the sender's company.