search

ActianCorp / Vector-Docker

Docker build file for creating a container with Actian Vector Community Edition
Apache License 2.0
10 stars 6 forks source link

Save space in final docker image #4

Closed orlandine closed 5 years ago

orlandine commented 5 years ago

Uses multistage build to discard installation artifacts prior to finalization.

orlandine commented 5 years ago

Btw, docker build should be run with --squash option.

monda07 commented 5 years ago

A couple observations: The Docker documentation still listed --squash as an experimental feature. As such I don't think it is appropriate to refer to yet as a standard practice. Someone familiar with these features would already know about squash and wouldn't need it in the official documentation. Plus, you have to specifically enable experimental features. That's fine for knowledgable people.

I have experimental turned on and using squash resulted in no improvement in storage use. actian/vector5.0 squash d4b70f67b3f6 2 hours ago 1.94GB actian/vector5.0 community 11932dd51fa9 3 hours ago 1.94GB

orlandine commented 5 years ago

Agree on the experimental state of --squash. Background:

vector:community 1.99GB <= default vector:multistage 2.9GB <= not good :) vector:squash 1.55GB <= squash makes sense with multistage build

monda07 commented 5 years ago

Docker still has squash marked as experimental. As a result we will leave it to the developer to decide if squash is necessary.