search

ActianCorp / actian_tableau_connector

Tableau connector (aka taco) for Actian Avalanche, Vector, and Ingres
https://extensiongallery.tableau.com/products/936
Apache License 2.0
1 stars 4 forks source link

Addition TIME1899() doc updates #33

Open clach04 opened 1 year ago

clach04 commented 1 year ago

Follow on from https://github.com/ActianCorp/actian_tableau_connector/pull/32 - comment https://github.com/ActianCorp/actian_tableau_connector/pull/32#issuecomment-1703526199

Requested Change 1

The explanation you have in the merge description is worth placing in code comments (i.e. XML comments), including the link to https://github.com/tableau/connector-plugin-sdk/blob/4cbc26c6c358224774cb8e5371f6b5292dbe531c/samples/components/dialects/SQLDialect.tdd#L51C38-L51C38

Requested Change 2

I want to see more information/explanation about why our implementation is returning time rather than datetime and why it is not using the magic date of 1899-12-30. My reading was that Tableau doesn't have a proper time datatype based on the explanation, I'm wondering if perhaps this is a workaround Tableau has for DBMS that don't have time only?