search

ActianCorp / actian_tableau_connector

Tableau connector (aka taco) for Actian Avalanche, Vector, and Ingres
https://extensiongallery.tableau.com/products/936
Apache License 2.0
1 stars 4 forks source link

TDVT DATENAME and DATEPART fixes with SOW = monday for II-12238 and II-12239 #36

Closed hab6 closed 12 months ago

hab6 commented 12 months ago

Summary

Remedy for failures that occur in TDVT test cases datename.sow.week and datepart.sow.week with sow='monday' using the Actian JDBC Connector. A couple other minor formatting issues were also fixed.

Affected TDVT Test Cases

JIra Issue Test Name Test Case
II-12238 date.datename.sow.week DATENAME('week', [date2], 'monday')
DATENAME('week', [datetime0], 'monday')
II-12239 date.datepart.sow.week DATEPART('week', [date2], 'monday')
DATEPART('week', [datetime0], 'monday')

Important Note: The test cases involving field date2 are not yet passing due to Connector SDK issue #1182. If the Tableau Connector SDK team agrees to update the expected files, this should allow the two date2 tests to pass.

TDVT Results

Note Passed Failed Total
Before Fix 837 31 868
After Fix 839 29 868

Test Results

test_results_combined-BEFOREFIXES.csv test_results_combined-AFTERFIXES.csv

hab6 commented 11 months ago

Additional information about this issue:

The fix is correct, but for the DATENAME and DATEPART tests cases involving the date2 column, the corresponding TDVT canon files are incorrect. See issue 2 for details.