ActianCorp / actian_tableau_connector

Tableau connector (aka taco) for Actian Avalanche, Vector, and Ingres
https://extensiongallery.tableau.com/products/936
Apache License 2.0
1 stars 4 forks source link

[Tableau Feedback] Create a properties builder script #6

Closed jainam1995 closed 1 year ago

jainam1995 commented 4 years ago

Since your connector was started, we've changed our samples to better reflect best practices for JDBC. You can read about the connection properties script in our documentation, and we have a sample jdbc plugin that uses the connection properties script. Note that you'll need to change your connection builder script to match the sample as well.

Basically, the formatted params are set int he connection properties script. This has implications in Tableau, and will make sure we treat the properties correctly (for example, not logging the password value).

Note that connection properties has two different possible return values, either a javascript object or a string formatted to have key=value. The javascript object is preferred since it does not have trouble with an equals sign in a property, but was only introduced in 2019.4.1.

Let me know you if have any questions, or if there are clarifications I can make.

clach04 commented 4 years ago

@jainam1995 Can you confirm (or deny ;)) this https://github.com/tableau/connector-plugin-sdk/blob/master/samples/plugins/postgres_jdbc/connectionProperties.js is only for JDBC?

We're using connectionHelper in ODBC as well as JDBC:

clach04 commented 4 years ago

Internal ref II-5538

hab6 commented 1 year ago

@jainam1995 I am following up on this old issue and specifically the comment by @clach04. Could you please confirm whether the connection-properties applies only to JDBC connectors or also to ODBC connectors? It is not clear to me since both JDBC and ODBC connectors use JavaScript connectionBuilder.js files.

hab6 commented 1 year ago

Added tag connection-properties and file connectionProperties.js in the JDBC connector code via PR #26.