search

ActionRetro / FrogFind

Source for the FrogFind search engine for vintage computers
GNU General Public License v3.0
212 stars 45 forks source link

Search result links don't work properly on Netscape 1.12 for MacOS #5

Open jonthysell opened 3 years ago

jonthysell commented 3 years ago

I can browse the site fine, and start a search. However, in the search results, every link has weird extra single quotes, i.e.:

http://frogfind.com/'/read.php?a=http%3A%2F%2Fexample.com'

The links look fine once I get into a real page, say on Wikipedia.

jonthysell commented 3 years ago

Correction: The links to other pages on a page look fine, links to the images at the top of the page also have the weird extra quotes which break the links.

jonthysell commented 3 years ago

20210505_101057

xFuney commented 3 years ago

If possible, could you provide a "view source" or Inspect Element view so we can eliminate the possibility of the browser being at fault? Thanks.

jonthysell commented 3 years ago

Looking at the source, it appears Netscape 1.12 doesn't like when attribute values use single quotes instead of double quotes.

This doesn't work: <a href='read.php'>text</a>.

But this does: <a href="read.php">text</a>.

So while the article content uses double quotes for all HTML attribute values, the HTML for the search results and the extracted image links at the top of the page use single quotes.

While I understand that technically the HTML 2.0 spec allows for single quotes, unless there's some browser out there that only accepts single quotes, my guess is it would only help to standardize the whole page with double quotes.

xFuney commented 3 years ago

That does sound like it could be causing the issue. I think there's plans to mitigate this eventually. Just keep tabs on the pull requests or, if you wish, make the changes yourself and submit a pull request.

lukecyca commented 1 year ago

A fix appears to be posted: #10