Closed hannomalie closed 8 years ago
Thanks, Hannes!
I’ve merged your pull request. We really do appreciate the input!
Best,
Dan V.
From: Hannes [mailto:notifications@github.com] Sent: Friday, October 9, 2015 11:22 AM To: ActionableAgile/jira-to-analytics jira-to-analytics@noreply.github.com Subject: [jira-to-analytics] Fetching with pagination (#8)
Hey guys,
I changed your code so that the standard pagination is used and fetching is done without the key indirection you used before. Without this change, the fetching was not correct because not all queried datasets were fetched. I tested the implementaiton with an internal jira at our company and it worked for me.
Since I'm not a Go developer, I would ask kindly to review my code and integrate everything if it's ok.
Thank you :)
You can view, comment on, or merge this pull request online at:
https://github.com/ActionableAgile/jira-to-analytics/pull/8
Commit Summary
File Changes
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/ActionableAgile/jira-to-analytics/pull/8 .
Hey guys,
I changed your code so that the standard pagination is used and fetching is done without the key indirection you used before. Without this change, the fetching was not correct because not all queried datasets were fetched. I tested the implementaiton with an internal jira at our company and it worked for me.
Since I'm not a Go developer, I would ask kindly to review my code and integrate everything if it's ok.
Thank you :)