search

Active-CSS / active-css

The epic event-driven browser language for UI with functionality in one-liner CSS. Over 100 incredible CSS commands for DOM manipulation, ajax, reactive variables, single-page application routing, and lots more. Could CSS be the JavaScript framework of the future?
https://activecss.org
Other
42 stars 7 forks source link

Error when closing photoswipe modal with incomplete URL #219

Closed bob2517 closed 2 years ago

bob2517 commented 2 years ago

When closing a photoswipe popup when using with ACSS, if the URL is incomplete from Photoswipe then the ACSS SPA internal code brings up an error. This would happen with any external JS that changes the URL if it's an incomplete URL. Functionality does work for a non-SPA, but it brings up this error when it tries to tie into the SPA functionality in ACSS.

I don't have a further use case beyond this yet as I'm not using ACSS as an SPA with photoswipe, and so don't see any implications beyond the error yet, and it seems to work ok, so I'm just going to fix the error for now.

If anyone uses photoswipe with ACSS in an SPA and it doesn't work as expected, let me know.

bob2517 commented 2 years ago

Fix now on branch. Will confirm fix when back at work - marking as more testing needed.