search

Active-CSS / active-css

The epic event-driven browser language for UI with functionality in one-liner CSS. Over 100 incredible CSS commands for DOM manipulation, ajax, reactive variables, single-page application routing, and lots more. Could CSS be the JavaScript framework of the future?
https://activecss.org
Other
41 stars 7 forks source link

Nested @while true with pause causing recursion error #334

Closed bob2517 closed 10 months ago

bob2517 commented 10 months ago

As per title. This did originally work, and it looks like it broke as collateral damage when a more severe issue related to nested statements mixed with the pause command and conditionals was fixed. It's specifically related to @while and not the other loop types.

bob2517 commented 10 months ago

Note to self for checking: Ensure references to inner loop are fully removed once broken out.

bob2517 commented 10 months ago

Fixed on branch. The error was on a nested @while loop with pause resumption. If naturally breaking out of a while loop, the resumption reference needed to be set to false so that it would not be entered at that point if resumed. The fix was to set the run result of the breaking out to false if not a pause.

Will test this in production as a final check.

bob2517 commented 10 months ago

Closing ready for release.