search

Active-Travel-Academy / ata-traffic-recorder

MIT License
3 stars 0 forks source link

some journeys skipped #13

Closed AnnaGoodman1 closed 3 years ago

AnnaGoodman1 commented 3 years ago

There seems to be a bug where some journey sometimes get skipped.

I have repeatedly run this in psql

update journeys set disabled=FALSE where id>=5428 and id<=5471 ;

and the resulting journeys are enabled run once and then disabled (because there type is test_routing)

As per the table below, in some runs all 44 are run but in several some are skipped – not always the same ones each time. Could you look into this?

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

Run | N runs / 44 | ones missiong -- | -- | -- 21208 | 44 |   21209 | 44 |   21210 | 44 |   21211 | 44 |   21212 | 41 | 5453,  5454,  5455 21213 | 40 | 5462,5463, 5464 , 5465 21214 | 44 |   21215 | 43 | 5464
AnnaGoodman1 commented 3 years ago

I noticed it most acutely in this set of multiple short journeys, made me wonder if there could be some sort of maximum requests per minute timeout.

nikolai-b commented 3 years ago

I don't see this:

select run_id, count(*) from journey_runs where run_id between 21208 and 21215 group by run_id;

 run_id | count 
--------+-------
  21208 |    44
  21209 |    44
  21210 |    44
  21211 |    44
  21212 |    44
  21213 |    44
  21214 |    44
  21215 |    44
AnnaGoodman1 commented 3 years ago

Oh right sorry I see – those journeys are there I just couldn't see them in the export I did. That is because the csv files were sorted by column A and that was weirdly formatted so was not listing everything strictly chronologically