search

ActiveBrainAtlas2 / activebrainatlasadmin

This is the ActiveBrainAtlas database portal. This project provides the admin area to edit data associated with the Active Brain Atlas project. It also provides the REST API.
0 stars 1 forks source link

Adding a vertex in edit mode breaks other vertices apart #130

Closed mm6654 closed 1 year ago

mm6654 commented 2 years ago

I am testing the volume tool by drawing a sub-region polygon within a main region polygon. One issue that appears on both polygons is that if the user is in "edit mode" and decides to add a vertex point, then moving any surrounding vertex points next to the added one will separate the vertices. All separated vertices can be moved around, and the annotations can even be saved even though the polygon is not closed. I also tested the propagation tool and it copies the disconnected polygon to the next section.

Screen Shot 2022-11-01 at 1 43 58 PM Screen Shot 2022-11-01 at 1 53 42 PM Screen Shot 2022-11-01 at 1 54 49 PM

Additionally, you can delete a vertex point that is in between two other vertices, but any edge vertices cannot be deleted.

Screen Shot 2022-11-01 at 1 56 15 PM
bruce-wayne99 commented 2 years ago

Duplicate issue: https://github.com/ActiveBrainAtlas2/activebrainatlasadmin/issues/105

keeping this open.

bruce-wayne99 commented 2 years ago

This has been fixed. @mm6654 this requires redrawing the polygons in which the bug took place.

bruce-wayne99 commented 2 years ago

Ui/annotations.ts contains the code for fixing this.

bruce-wayne99 commented 2 years ago

Issue occurs when all the points are not in the same plane. For example the current vertices in the polygon are in section: 234.50001 but the newly created point is at location 234.5 hence the issue.

bruce-wayne99 commented 1 year ago

This issue has been fixed. Reproduced at link: https://webdev.dk.ucsd.edu/preview/?id=393

Now the vertices don't break.