ActiveCampaign / activecampaign-api-php

MIT License
115 stars 76 forks source link

Unclear of how to use parameters #51

Closed jonathan-s closed 6 years ago

jonathan-s commented 8 years ago

I was trying this $fields = $ac->api("list/field/view", array("ids" => "all"); and it gave me no result at all. Then 40 minutes later in a moment of inspiration I tried this $fields = $ac->api("list/field/view?ids=all"); which worked. Please document the behaviour!

And I would much prefer the first way of doing things because it feels a lot more natural.

(ping @ac-pevans)

femiagbabiaka commented 7 years ago

Thanks @jonathan-s! I've added some documentation here: (https://github.com/ActiveCampaign/activecampaign-api-php/pull/60). Could you let me know what you think?

jonathan-s commented 7 years ago

👍

On Tue, 4 Oct 2016, 17:47 Femi Agbabiaka, notifications@github.com wrote:

Thanks @jonathan-s https://github.com/jonathan-s! I've added some documentation here: (#60 https://github.com/ActiveCampaign/activecampaign-api-php/pull/60). Could you let me know what you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ActiveCampaign/activecampaign-api-php/issues/51#issuecomment-251444650, or mute the thread https://github.com/notifications/unsubscribe-auth/ACBsEvp9V4i8lqRJngPyr798YZNLLzTDks5qwoMNgaJpZM4JjOx- .

chrisbell08 commented 7 years ago

For anyone else who stumbles on this when trying to get a list of all lists this works for that too, ex. $this->ac->api('list/list?ids=all');

cristiangrama commented 6 years ago

Addressed in #60