search

ActiveCampaign / activecampaign-api-php

MIT License
115 stars 76 forks source link

Code Style Clean Up and Removal of Debug Function #86

Closed bartboy011 closed 6 years ago

bartboy011 commented 6 years ago

This PR raises the repo to PSR-2 standards, with a few exceptions (no namespacing, no using non-camelcase method names). Additionally, it removes the dbg() method and all instances of if($this->debug). Finally, it adds linting to the repo via PHP_Codesniffer.

bartboy011 commented 6 years ago

@ActiveCampaign/integration

mthommes commented 6 years ago

@bartboy011 @cristiangrama The debug feature is useful for support troubleshooting. Is there an alternative & better way of doing this? If so I think we should document that somehow.

bartboy011 commented 6 years ago

@cristiangrama @mthommes This should be ready to go for a review now

bartboy011 commented 6 years ago

@cristiangrama This was approved (not sure you get the notifications)