search

ActiveCampaign / activecampaign-api-php

MIT License
115 stars 76 forks source link

Change Credentials Test Method to Throw Exception #90

Closed bartboy011 closed 6 years ago

bartboy011 commented 6 years ago

This PR updates the method Connection#credentials_test to throw an exception if there are invalid credentials rather than returning a boolean. This will allow for developers to better see the cause of the credential failure.

@ActiveCampaign/integration

bartboy011 commented 6 years ago

@dudemelo I got an email notification that you had left a comment on this PR, but now can't find it. Is it still in existence?

dudemelo commented 6 years ago

@bartboy011 sorry, I hadn't realized it was a test method.

bartboy011 commented 6 years ago

@dudemelo Not a problem, thanks for reviewing!