Closed derekrushforth closed 3 years ago
yep, will check today hombre
Note: I think that you should also check "LayoutTemplate" when checking for name, subject, HTML, and text version for comparison
@ibalosh Ah! Great suggestion. I will include that today.
hey @derekrushforth
thanks! other than that, looks good, tried comparison and preview of subject, both worked like charm
(for me too it did not work in node 7, got error when trying preview)
hey @derekrushforth also, this is more of a tuning if you would like to do and you probably know about it: if you click link in page which is not setup in meta.json to be a link, error will be thrown (maybe we could catch an error and just do nothing on the page?) This happens when using default templates with default variable field values in json
@ibalosh Good catch. Layout templates are now being checked and clicking on a link will no longer throw an error. For now, it's going to show this page since the template can't be found:
Looks like our node 7 build failures are being caused by this. The clientOptions
property is private and can only be accessed within the BaseClient
class. I'm a little stumped on how to work around this so I will fix this separately. This functionality allows us to specify a staging URL when requesting data from our API.
Gotcha, all looks now ok, only if I use real URLs now (like https://www.google.com), it acts weird and wont open them. From what I see it seems it complains that it tries to open them in a frame or something. If it would be a new tab it would work
once I click open site in new window in Firefox it would work
@ibalosh Just pushed an update that makes all links inside the template open up in a new window by default. This behavior is ideal since it doesn't interfere with the template preview iframes.
I did this by appending the <base target="_blank" />
tag to all of the template previews. The tag will not be included when pushing to PM.
looks great now, tx!
Hey @ibalosh!
Can you QA these improvements when you get the chance? Here's a rundown of what's changing:
Render subject line syntax on previews +
When previewing a template, the subject lines are now compiled through our system so that you can see how they look with your test model. Something that previously looked like this:
Now looks like this:
Validation errors returned from our API will be visible via tooltip:
Related #28
Smarter template pushing
postmark templates push
currently pushes all of your templates up to Postmark regardless of whether or not they were modified. The new default behavior will now compare your local template's name, subject, HTML, and text version with the corresponding template in Postmark and only push if it has been modified. This will provide a more accurate representation when reviewing what actually changed.If you run the push command and there are no changes, the console output will return:
You can also force push all of your templates up to Postmark, regardless of whether or not they were modified using the
--all
or-a
arg.This arg now also tells you if the template was "Unmodified" in the review output.
Related #14
The builds are failing in node 7 for some reason. I'll look into this. Let me know if you have any questions. Thanks!