search

ActiveCampaign / postmark-wordpress

The Official Postmark Wordpress Plugin
GNU General Public License v2.0
17 stars 17 forks source link

Support tags #103

Closed pgraham3 closed 1 year ago

pgraham3 commented 1 year ago

Extracted from https://github.com/ActiveCampaign/postmark-wordpress/pull/67

DorZuberi commented 1 year ago

+1

pgraham3 commented 1 year ago

Hey @DorZuberi would you mind giving this PR a look and suggest any changes?

I am specifically wondering about your request for a filter as I am not super familiar with those beyond using core hooks and wondering if my proposed implementation would do the job. PHP and WordPress aren't core competencies of ours at ActiveCampaign Postmark so would appreciate any feedback on these changes.

Thanks!

DorZuberi commented 1 year ago

Hi @pgraham3, Looks great!

pgraham3 commented 1 year ago

@DorZuberi This has been released as version 1.18.0. Thanks for the help! Added you as a contributor in the plugin marketplace listing 🫡.

Screenshot 2023-03-17 at 10 27 32 AM
DorZuberi commented 1 year ago

Wow! Thanks!

I'm actually wanted to fork the repo and send you a PR with additional changes and aligning the plugin to WordPress's code conventions.

pgraham3 commented 1 year ago

That would be awesome! There are definitely improvements to be made to this plugin but I don't always have the time/experience to implement them, unfortunately. I work with Ruby/Rails/JavaScript day to day so some of the WordPress conventions and general PHP dev process like adding tests are not strong suits of mine.

@bhubbard also has some useful PRs to setup CI and automated tests, deploy to SVN from a Github action, and more for us here that could use an experienced reviewer. If you ever feel like contributing more that would be super helpful too.

Thanks again!

DorZuberi commented 1 year ago

Will do! Thanks!

I'm a long time user of Postmark, truly an amazing product. The company which I work in also uses Postmark for a few years.

Keep up the good work! ❤️