search

ActiveCampaign / postmark-wordpress

The Official Postmark Wordpress Plugin
GNU General Public License v2.0
17 stars 17 forks source link

Fixing syntax parse error. #19

Closed renatonascalves closed 7 years ago

renatonascalves commented 7 years ago

The code was using php functions, <? ?>, that were causing problems in my site. Not allowing the settings page to be shown.

Here is the log of the error: [21-Mar-2017 13:10:34 UTC] PHP Parse error: syntax error, unexpected end of file in /srv/www/opera/htdocs/wp-content/plugins/postmark-wordpress/page-settings.php on line 144

The proposed changes fixed this error and the settings page is showing again.

renatonascalves commented 7 years ago

Sorry about the tab change... My sublime text automatically changes it. :(

atheken commented 7 years ago

@renatonascalves, thanks for the PR. Can you try to fix the indentation back to what it was? The entire file appears to have changed, though I am thinking this is a minor change?

renatonascalves commented 7 years ago

Sure! I'll fix it!

renatonascalves commented 7 years ago

Indentation went back to spaces instead of tabs.

atheken commented 7 years ago

Thanks! Just curious, what version of PHP are you running where this was creating an error?

renatonascalves commented 7 years ago

Nginx / PHP 7.17 Btw @atheken I don't think this is so minor. Without this fix, this is how I see it:

screenshot_1