ActiveCampaign / postmark-wordpress

The Official Postmark Wordpress Plugin
GNU General Public License v2.0
17 stars 17 forks source link

Added localization #20

Closed renatonascalves closed 5 years ago

renatonascalves commented 7 years ago

Added the base to allow other languages to translate from.

cfoellmann commented 5 years ago

@renatonascalves I really like your PR!! But I learned the hard way that PRs that go above and beyond the scope are very hard on the maintainers and reviewers.

Keep the scope narrow and start with the core of what you want to acchieve. I would love if you were to re-submit the changes to all the text strings! Plus the headers. You need to use the text-domain 'postmark-approved-wordpress-plugin' to support the wp.org translation platform.

renatonascalves commented 5 years ago

@cfoellmann Thanks! I have no plan to engage in that in the near future. If someone else would like to take the chance, feel free. :)

cfoellmann commented 5 years ago

I see that waiting for 1 year on a reply is not very encouraging :-( I hope for myself that this will change.