search

ActiveCampaign / postmark-wordpress

The Official Postmark Wordpress Plugin
GNU General Public License v2.0
17 stars 17 forks source link

WordPress Coding Standards #28

Closed bhubbard closed 4 years ago

bhubbard commented 7 years ago

Im looking to possibly use this plugin on many sites, and wanted to help contribute to the plugin. This pull request goes thru and fixes many of the errors reported by PHPCS when testing against WordPress Coding Standards.

cfoellmann commented 5 years ago

I really love this!! A lot of your changes are great.

I am just starting to deploy the plugin and would really appreciate improvements to the plugin. The problem of your PR is the very broad scope.

By contributing a lot in the past to open source I learned that evaluating contributions gets a lot harder when the PR is very complex.

You should split this into at least 5 independent PRs. That way the maintainers can evaluate quickly. This makes it easier for them and you have better success with your hard work.