search

ActiveCampaign / postmark-wordpress

The Official Postmark Wordpress Plugin
GNU General Public License v2.0
18 stars 17 forks source link

Add option to force the from email #82

Closed MultiSuperFreek closed 2 years ago

MultiSuperFreek commented 2 years ago

As an agency, we work with a multitude of form plugins, contact forms and site maintainers. We usually set up Postmark using this plugin, but site administrators can and do change emailadresses, and sometimes change the wrong email, breaking the DKIM validation and not sending all email following. I would like to be able to force the sender email, so people don't accidentally break all email by changing the admin email for example.

This PR adds a setting (default off) to force a from email, and if this is enabled, doesn't allow the $headers['From'] to override the from email.

pgraham3 commented 2 years ago

@MultiSuperFreek Hello - there is a report of the new plugin setting not being honoured when it is disabled.

https://wordpress.org/support/topic/1-15-always-overriding-from-header-while-checkbox-is-disabled/#post-15162665

Can you please take a look?

I have reverted the production plugin to previous version 1.14.0 in the meantime. Tag 1.15.0 is still available for development purposes in the SVN repo for the plugin.

Please use a new PR for any fix(es) for v1.15

Thanks!

MultiSuperFreek commented 2 years ago

@MultiSuperFreek Hello - there is a report of the new plugin setting not being honoured when it is disabled.

https://wordpress.org/support/topic/1-15-always-overriding-from-header-while-checkbox-is-disabled/#post-15162665

Can you please take a look?

I have reverted the production plugin to previous version 1.14.0 in the meantime. Tag 1.15.0 is still available for development purposes in the SVN repo for the plugin.

Please use a new PR for any fix(es) for v1.15

Thanks!

@pgraham3 I will look into this tomorrow!

MultiSuperFreek commented 2 years ago

@pgraham3 I've created a new PR #83 with the fixes.