Add phone/auth endpoint

ActiveLogin / ActiveLogin.Authentication

Support Swedish BankID (svenskt BankID) authentication in .NET. Unofficial package, not created by BankID.

https://activelogin.net

MIT License

216 stars 75 forks source link

Add phone/auth endpoint #420

Closed Korla closed 1 year ago

Korla commented 1 year ago

This PR fixes #NNN.

High level overview of this PR:

[ ] A
[ ] B
[ ] C

These things have been implemented (when relevant):

[ ] Code written
[ ] Test added
[ ] Documentation updated / written

PeterOrneholm commented 1 year ago

Hi @Korla!

Thanks for showing interest in Active Login :) Unfortunately, I can't merge your PR as it is now.

Please have a look at our contribution guidelines here for details on what you need to do: https://github.com/ActiveLogin/ActiveLogin.Authentication/blob/main/CONTRIBUTING.md

In addition, we would need the code to be complete before merging with no NotImplementedException.

Korla commented 1 year ago

That is of course reasonable, I was trying to make this change in my own fork, but apparently my remote was misconfigured. Sorry for the hassle. I might get back in a while with a proper PR.